[webkit-reviews] review granted: [Bug 98315] Turn Compositing on by default in WebKit build : [Attachment 167023] fixed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 10:07:37 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rik Cabanier
<cabanier at adobe.com>'s request for review:
Bug 98315: Turn Compositing on by default in WebKit build
https://bugs.webkit.org/show_bug.cgi?id=98315

Attachment 167023: fixed patch
https://bugs.webkit.org/attachment.cgi?id=167023&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167023&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   smfr said that this feature should be turned on and that browser can
elect to
> +	   pick it up

A better comment would be "enable this feature on trunk." I don't think any
further justification is required, but you might want to reference a bug or
bugs about enabling it on other platforms.

> Source/WebCore/css/CSSPropertyNames.in:8
>  //
> +
>  // Microsoft extensions are documented here:

Whitespace

> Source/WebCore/css/CSSValueKeywords.in:45
>  all
> +
>  //

Whitespace


More information about the webkit-reviews mailing list