[webkit-reviews] review granted: [Bug 98385] Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes. : [Attachment 167107] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 98385: Web Inspector: When uiSourceCode content has diverged from VM
script, call frames should be shown in temporary script based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=98385

Attachment 167107: Patch
https://bugs.webkit.org/attachment.cgi?id=167107&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167107&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:112
> +	   if (uiSourceCode.isDivergedReplacement)

divergedVersion: function()
{
    return uiSourceCode;
}

> Source/WebCore/inspector/front-end/JavaScriptSource.js:80
> +    fireHasDivergedFromVMChanged: function()

I would split it into "fileHasDiverged" and "fileWasMerged"