[webkit-reviews] review denied: [Bug 98387] [Qt][Mac] GL_ARB_texture_rectangle must be activated when using ANGLE. : [Attachment 167059] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 07:13:57 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 98387: [Qt][Mac] GL_ARB_texture_rectangle must be activated when using
ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=98387

Attachment 167059: patch for review.
https://bugs.webkit.org/attachment.cgi?id=167059&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167059&action=review


> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:211
> +    if
(m_platformContext->hasExtension(QByteArrayLiteral("GL_ARB_texture_rectangle"))
)
> +	   ANGLEResources.ARB_texture_rectangle = 1;

Please use Extensions3D


More information about the webkit-reviews mailing list