[webkit-reviews] review denied: [Bug 98333] [GTK] Enable inspector by default in GtkLauncher/MiniBrowser : [Attachment 167011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 04:33:33 PDT 2012


Xan Lopez <xan.lopez at gmail.com> has denied Adrian Perez <aperez at igalia.com>'s
request for review:
Bug 98333: [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98333

Attachment 167011: Patch
https://bugs.webkit.org/attachment.cgi?id=167011&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review


> Tools/GtkLauncher/main.c:492
> +    g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE,
NULL);

Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise
I guess we should try to use the same when thing possible.

r- because you need cq to land this, so please re-upload.


More information about the webkit-reviews mailing list