[webkit-reviews] review denied: [Bug 61675] <input> size attribute does not return default when attribute outofrange : [Attachment 167035] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 61675: <input> size attribute does not return default when attribute
outofrange
https://bugs.webkit.org/show_bug.cgi?id=61675

Attachment 167035: Patch
https://bugs.webkit.org/attachment.cgi?id=167035&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167035&action=review


> Source/WebCore/ChangeLog:3
> +	   <input> size attribute does not return default when attribute
outofrange

This is the bug title, but it doesn't match what you will fix.
It seems the original issue was already fixed, and you'll fix Comment #2,
right?	If so, we should change the bug title.

> Source/WebCore/html/HTMLInputElement.h:210
> -    void setSize(unsigned);
> +    void setSize(unsigned, ExceptionCode&);

Unfortunately Objective-C binding needs setSize(unsigned).  We should have
both.

> LayoutTests/ChangeLog:11
> +	   * fast/forms/input-size-expected.txt: Added.
> +	   * fast/forms/input-size.html: Added.

We already have fast/dom/HTMLInputElement/input-size-attribute.html.  Would you
add your test case to it please?