[webkit-reviews] review granted: [Bug 98203] PageLoad tests are multi-modal : [Attachment 167032] Update per reviewer comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 22:33:04 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 98203: PageLoad tests are multi-modal
https://bugs.webkit.org/show_bug.cgi?id=98203

Attachment 167032: Update per reviewer comments
https://bugs.webkit.org/attachment.cgi?id=167032&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167032&action=review


> Tools/Scripts/webkitpy/performance_tests/perftest.py:207
> +	   self.force_gc_file = port.perf_tests_dir() +
"/resources/force-gc.html"

There's port.host.filesystem.join. Use that instead of +.


More information about the webkit-reviews mailing list