[webkit-reviews] review granted: [Bug 98227] DateTimeYearFieldElement should respect min/max values specified by page authors : [Attachment 166854] Patch 2

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 98227: DateTimeYearFieldElement should respect min/max values specified by
page authors
https://bugs.webkit.org/show_bug.cgi?id=98227

Attachment 166854: Patch 2
https://bugs.webkit.org/attachment.cgi?id=166854&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166854&action=review


> Source/WebCore/html/shadow/DateTimeEditElement.cpp:164
> +	       yearParams.minIsSpecified = false;

Nit: could be
 yearParams.minIsSpecified = m_parameters.minimumYear !=
m_parameters.undefinedYear();

> Source/WebCore/html/shadow/DateTimeFieldElements.h:177
> +	       : minimumYear(-1)

Why not use undefinedYear()?