[webkit-reviews] review granted: [Bug 98327] Simplify attribute access in Element::computeInheritedLanguage : [Attachment 166993] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 16:53:15 PDT 2012


Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 98327: Simplify attribute access in Element::computeInheritedLanguage
https://bugs.webkit.org/show_bug.cgi?id=98327

Attachment 166993: Patch
https://bugs.webkit.org/attachment.cgi?id=166993&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review


r=me, though I suspect you could save a couple more cycles here by doing a
custom loop over the attributeData->attributeItem()s.

> Source/WebCore/dom/Element.cpp:1762
> +	       ElementAttributeData* attributeData = static_cast<const
Element*>(n)->attributeData();
> +	       if (attributeData) {

Scope 'attributeData' to the if.


More information about the webkit-reviews mailing list