[webkit-reviews] review granted: [Bug 98313] ScrollingStateNode should keep a Vector of children instead of child pointers : [Attachment 166983] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 16:11:51 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 98313: ScrollingStateNode should keep a Vector of children instead of child
pointers
https://bugs.webkit.org/show_bug.cgi?id=98313

Attachment 166983: Patch
https://bugs.webkit.org/attachment.cgi?id=166983&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166983&action=review


> Source/WebCore/ChangeLog:17
> +	   (WebCore):

(WebCore):

> Source/WebCore/page/scrolling/ScrollingStateNode.h:81
> +    Vector<OwnPtr<ScrollingStateNode> > m_children;

Maybe use a Vector* since many nodes won't have children.


More information about the webkit-reviews mailing list