[webkit-reviews] review granted: [Bug 98055] [soup] WebKit crashes when doing a http request : [Attachment 166943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 15:52:45 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted arno. <arno at renevier.net>'s
request for review:
Bug 98055: [soup] WebKit crashes when doing a http request
https://bugs.webkit.org/show_bug.cgi?id=98055

Attachment 166943: Patch
https://bugs.webkit.org/attachment.cgi?id=166943&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166943&action=review


> Source/WebCore/platform/network/ResourceRequestBase.cpp:41
> +#if USE(SOUP)
> +// soup timeout is defined with integers milliseconds. We set 0 as default
value to avoid integer overflow.
> +double ResourceRequestBase::s_defaultTimeoutInterval = 0;
> +#elif !PLATFORM(MAC) || USE(CFNETWORK)

:) This isn't quite what I asked for, but I'll make the change and land it for
you.


More information about the webkit-reviews mailing list