[webkit-reviews] review granted: [Bug 98212] [WK2] Support all attributes of GeolocationPosition : [Attachment 166795] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 98212: [WK2] Support all attributes of GeolocationPosition
https://bugs.webkit.org/show_bug.cgi?id=98212

Attachment 166795: Patch
https://bugs.webkit.org/attachment.cgi?id=166795&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166795&action=review


> Source/WebKit2/Shared/WebGeolocationPosition.cpp:56
> +    encoder->encode(CoreIPC::In(timestamp, latitude, longitude, accuracy,
canProvideAltitude, altitude, canProvideAltitudeAccuracy, altitudeAccuracy,
canProvideHeading, heading, canProvideSpeed, speed));

Instead of adding the overload of CoreIPC::In(), can you just call
encoder->encode multiple times.  That has become more idiomatic in our code.

> Source/WebKit2/Shared/WebGeolocationPosition.cpp:61
> +    return decoder->decode(CoreIPC::Out(data.timestamp, data.latitude,
data.longitude, data.accuracy, data.canProvideAltitude, data.altitude,
data.canProvideAltitudeAccuracy, data.altitudeAccuracy, data.canProvideHeading,
data.heading, data.canProvideSpeed, data.speed));

Same here.