[webkit-reviews] review denied: [Bug 95614] Add support for blendmode to platform code for mac : [Attachment 163315] renamed function per Simon Fraser's request

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 13:46:56 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rik Cabanier
<cabanier at adobe.com>'s request for review:
Bug 95614: Add support for blendmode to platform code for mac
https://bugs.webkit.org/show_bug.cgi?id=95614

Attachment 163315: renamed function per Simon Fraser's request
https://bugs.webkit.org/attachment.cgi?id=163315&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=163315&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1080
> +    if (m_uncommittedChanges & CompositingChanged)
> +	   updateBlending();

The 'changed' enum name should match the updateFoo.

> LayoutTests/css3/compositing/effect-blend-mode-expected.txt:3
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600

Is this useful as render tree ouput?


More information about the webkit-reviews mailing list