[webkit-reviews] review granted: [Bug 98205] Round image sizes when zooming : [Attachment 166941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 13:15:19 PDT 2012


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 98205: Round image sizes when zooming
https://bugs.webkit.org/show_bug.cgi?id=98205

Attachment 166941: Patch
https://bugs.webkit.org/attachment.cgi?id=166941&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166941&action=review


OK.

> Source/WebCore/loader/cache/CachedImage.cpp:268
> +    imageSize.setWidth(lroundf(imageSize.width() * widthScale));
> +    imageSize.setHeight(lroundf(imageSize.height() * heightScale));

We could have also written this in terms of LayoutUnit primatives and done this
w/o #ifdefs. :)


More information about the webkit-reviews mailing list