[webkit-reviews] review denied: [Bug 98252] Pair NDEBUG optioning in RefCountedBase. : [Attachment 166844] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 12:47:06 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 98252: Pair NDEBUG optioning in RefCountedBase.
https://bugs.webkit.org/show_bug.cgi?id=98252

Attachment 166844: patch
https://bugs.webkit.org/attachment.cgi?id=166844&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Your patch is correct. But I think we are abusing NDEBUG here. I would like a
new #define based on NDEBUG like we do in HashTable.

For example define CHECK_REF_COUNTED_LIFECYCLE if not NDEBUG.


More information about the webkit-reviews mailing list