[webkit-reviews] review denied: [Bug 98055] [soup] WebKit crashes when doing a http request : [Attachment 166938] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 98055: [soup] WebKit crashes when doing a http request
https://bugs.webkit.org/show_bug.cgi?id=98055

Attachment 166938: Patch
https://bugs.webkit.org/attachment.cgi?id=166938&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166938&action=review


Great! This is much, much simpler. Just one small change, I think.  

As an aside, I think this ambiguity between platforms isn't so great. It'd be
nice if there was a constant NoTimeout that consumers of this API could check
against. That could be another patch though.

> Source/WebCore/platform/network/ResourceRequestBase.cpp:44
> +#if USE(SOUP)
> +// soup timeout is defined with integers milliseconds. We set 0 as default
value to avoid integer overflow.
> +double ResourceRequestBase::s_defaultTimeoutInterval = 0;
> +#elif !PLATFORM(MAC) || USE(CFNETWORK)
>  double ResourceRequestBase::s_defaultTimeoutInterval = INT_MAX;
>  #else
>  // Will use NSURLRequest default timeout unless set to a non-zero value with
setDefaultTimeoutInterval().

This could be folded to be:

#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFNETWORK))
double ResourceRequestBase::s_defaultTimeoutInterval = INT_MAX;
#else
double ResourceRequestBase::s_defaultTimeoutInterval = INT_MAX;
#endif