[webkit-reviews] review granted: [Bug 98173] Allow EventHandler to handle longpress gestures, including longpress selection on Android. : [Attachment 166915] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Oli Lan <olilan at chromium.org>'s
request for review:
Bug 98173: Allow EventHandler to handle longpress gestures, including longpress
selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173

Attachment 166915: Patch
https://bugs.webkit.org/attachment.cgi?id=166915&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166915&action=review


Excellent! This patch looks much, much better.

> Source/WebCore/page/EventHandler.cpp:455
> +	   selectClosestWordFromHitTestResult(result.hitTestResult(),
(result.event().clickCount() == 2 &&
m_frame->editor()->isSelectTrailingWhitespaceEnabled()) ?
ShouldAppendTrailingWhitespace : DontAppendTrailingWhitespace);

This is a really long time. I would split into two lines (make sure to add
curly brackets around the if statement in that case).