[webkit-reviews] review denied: [Bug 98063] [GTK] [WK2] Add favicon support to the MiniBrowser : [Attachment 166669] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 06:10:30 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has denied Alberto Garcia
<agarcia at igalia.com>'s request for review:
Bug 98063: [GTK] [WK2] Add favicon support to the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98063

Attachment 166669: Patch v2
https://bugs.webkit.org/attachment.cgi?id=166669&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166669&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:370
> +	   cairo_surface_destroy(surface);

webkit_web_view_get_favicon() now returns transfer none, so you shouldn't
destroy the surface.


More information about the webkit-reviews mailing list