[webkit-reviews] review requested: [Bug 98153] [GTK] WebKitWebView doesn't emit notify:favicon when it changes in some cases in WebKit2 : [Attachment 166855] Updated patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 98153: [GTK] WebKitWebView doesn't emit notify:favicon when it changes in
some cases in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=98153

Attachment 166855: Updated patch
https://bugs.webkit.org/attachment.cgi?id=166855&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Addressed review comments, workaround style issues, and fix the unit tests. The
problem as a special case that happens when you as for an icon when it's being
loaded and the database initial import is ongoing, something that it's unlikely
to happen in a real app, but always happens in unit tests because things are
done too early and fast. In such case the icon-data-ready callback can be
called before the favicon has been loaded. With this patch WebKitWebView now
does the right thing, so instead of waiting for the icon-ready signal, we can
wait for the notify::favicon signal os WebKitWebView that will be emitted when
the favicon data is actually ready.