[webkit-reviews] review granted: [Bug 98163] Web Inspector: "Load profile..." context menu item has to be shown only for left column with the list of profiles. : [Attachment 166708] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 98163: Web Inspector: "Load profile..." context menu item has to be shown
only for left column with the list of profiles.
https://bugs.webkit.org/show_bug.cgi?id=98163

Attachment 166708: Patch
https://bugs.webkit.org/attachment.cgi?id=166708&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166708&action=review


> Source/WebCore/inspector/front-end/ProfilesPanel.js:1253
> +	   if (profile.canSaveToFile()) {

Should it be a test for heap snapshot profile type + canSaveToFile as otherwise
it is a bit confusing that all the titles include "Heap Snapshot" ?