[webkit-reviews] review granted: [Bug 98003] Add data passing to the GetStats interface of RTCPeerConnection : [Attachment 166676] Review comments addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 2 22:01:30 PDT 2012
Adam Barth <abarth at webkit.org> has granted Harald Alvestrand <hta at google.com>'s
request for review:
Bug 98003: Add data passing to the GetStats interface of RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=98003
Attachment 166676: Review comments addressed
https://bugs.webkit.org/attachment.cgi?id=166676&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This seems fine modulo the nits above. I probably would have continued to use
the descriptor pattern that we're using elsewhere in mediastream because it
avoids the virtual function calls and the static_casts, but this way works too.
More information about the webkit-reviews
mailing list