[webkit-reviews] review granted: [Bug 98228] Refactoring: DateTimeEditBuilder had better hold LayoutParameters : [Attachment 166803] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 98228: Refactoring: DateTimeEditBuilder had better hold LayoutParameters
https://bugs.webkit.org/show_bug.cgi?id=98228

Attachment 166803: Patch
https://bugs.webkit.org/attachment.cgi?id=166803&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166803&action=review


Looks OK.

> Source/WebCore/ChangeLog:9
> +	   constructor. This change improves code size and runtime cost.

This change increases the size of a DateTimeEditBuilder object. I don't think
this is a big deal, but please just keep it in mind:

Before:
const StepRange m_stepRange;
Localizer& m_localizer;
const String m_placeholderForDay;
const String m_placeholderForMonth;
const String m_placeholderForYear;

After:
String dateTimeFormat;
String fallbackDateTimeFormat;
Localizer& localizer;
const StepRange stepRange;
String placeholderForMonth;
String placeholderForYear;

> Source/WebCore/ChangeLog:19
> +	   Add m_parmaeters.

Typo: m_parmaeters