[webkit-reviews] review granted: [Bug 98225] Shrink ElementRareData by moving bool flags to NodeRareData. : [Attachment 166800] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 20:29:43 PDT 2012


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 98225: Shrink ElementRareData by moving bool flags to NodeRareData.
https://bugs.webkit.org/show_bug.cgi?id=98225

Attachment 166800: Patch
https://bugs.webkit.org/attachment.cgi?id=166800&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review


r=me

> Source/WebCore/ChangeLog:9
> +	   Move all bool flags from ElementRareData to the bitfield in its base
class NodeRareData.
> +	   This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed
some double raredata hash lookups.

Would be nice to tell why this is worth doing.


More information about the webkit-reviews mailing list