[webkit-reviews] review granted: [Bug 98203] PageLoad tests are multi-modal : [Attachment 166755] Force GC between PageLoad tests.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 98203: PageLoad tests are multi-modal
https://bugs.webkit.org/show_bug.cgi?id=98203

Attachment 166755: Force GC between PageLoad tests.
https://bugs.webkit.org/attachment.cgi?id=166755&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166755&action=review


> Tools/Scripts/webkitpy/performance_tests/perftest.py:210
> +	   driver.run_test(DriverInput("resources/forceGC.html", time_out_ms,
image_hash=None, should_run_pixel_test=should_run_pixel_test),
stop_when_done=False)

You can just pass False to should_run_pixel_test.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:211
> +	   return driver.run_test(DriverInput(path_or_url, time_out_ms,
image_hash=None, should_run_pixel_test=should_run_pixel_test),
stop_when_done=False)

Maybe we should call super(ReplayPerfTest, self).run_single instead?

> LayoutTests/ChangeLog:16
> +	   * resources/forceGC.html: Added.

How about force-gc.html? or ForceGC.html. I don't think we use camelCase for
file names.