[webkit-reviews] review granted: [Bug 97895] [GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+ : [Attachment 166223] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 97895: [GTK] Add API to get the web view that initiated a custom URI
request to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=97895

Attachment 166223: Patch
https://bugs.webkit.org/attachment.cgi?id=166223&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166223&action=review


Okay. This looks good to me. I wish there was a cleaner way to get the frame
from the networking request, but

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:700
> +    uint64_t* initiatingPageIDPtr = g_slice_new(uint64_t);

You should use FastAlloc instead of the GLib allocator here.

>> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703
>> +			      
reinterpret_cast<GDestroyNotify>(initiatingPageIDPtrFree));
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

Please fix this before landing.