[webkit-reviews] review denied: [Bug 80992] Web Inspector: provide a way to reload page with given script preprocessor. : [Attachment 166718] Rebase + one fix: ScriptDebugServer::setScriptSource callDebuggerMethod(liveEditScriptSource... because the JS method was renamed

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 80992: Web Inspector: provide a way to reload page with given script
preprocessor.
https://bugs.webkit.org/show_bug.cgi?id=80992

Attachment 166718: Rebase + one fix: ScriptDebugServer::setScriptSource
callDebuggerMethod(liveEditScriptSource... because the JS method was renamed
https://bugs.webkit.org/attachment.cgi?id=166718&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166718&action=review


> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:133
> +	       if (!m_preprocessorFunction.IsEmpty()) {
> +		   m_preprocessorFunction.Dispose();
> +		   m_preprocessorFunction.Clear();
> +	       }

Whenever you find yourself writing code like this, please use ScopedPersistent
instead.

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:144
> +    v8::Persistent<v8::Context> m_utilityContext;

Please use ScopedPersistent rather than holding raw persistent handles in
member variables.