[webkit-reviews] review granted: [Bug 98144] Fixed position visibility check does not consider descendants : [Attachment 166666] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 2 11:49:23 PDT 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 98144: Fixed position visibility check does not consider descendants
https://bugs.webkit.org/show_bug.cgi?id=98144
Attachment 166666: Patch
https://bugs.webkit.org/attachment.cgi?id=166666&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166666&action=review
> Source/WebCore/rendering/RenderLayerCompositor.cpp:1859
> + IntRect layerBounds = calculateCompositedBounds(layer,
rootRenderLayer());
calculateCompositedBounds is doing a subtree walk, which could be expensive.
>
LayoutTests/compositing/layer-creation/fixed-position-absolute-descendant.html:
30
> + window.internals.settings.setEnableCompositingForFixedPosition(true);
> +
window.internals.settings.setFixedPositionCreatesStackingContext(true);
Are these both correctly reset by InternalSettings between tests?
More information about the webkit-reviews
mailing list