[webkit-reviews] review granted: [Bug 98174] Unix plugin process: xErrorString does not need to be defined in release builds : [Attachment 166707] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adrian Perez <aperez at igalia.com>'s
request for review:
Bug 98174: Unix plugin process: xErrorString does not need to be defined in
release builds
https://bugs.webkit.org/show_bug.cgi?id=98174

Attachment 166707: Patch
https://bugs.webkit.org/attachment.cgi?id=166707&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166707&action=review


> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:54
> +#ifndef LOG_DISABLED
>  static const char* xErrorString = "The program '%s' received an X Window
System error.\n"
>      "This probably reflects a bug in a browser plugin.\n"
>      "The error was '%s'.\n"
>      "  (Details: serial %ld error_code %d request_code %d minor_code %d)\n";

> +#endif /* !LOG_DISABLED */

Could also make this a bit more const. Either const char[] or const char*
const.