[webkit-reviews] review granted: [Bug 97993] [Chromium] Introduce caches for HarfBuzzShaper : [Attachment 166595] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97993: [Chromium] Introduce caches for HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97993

Attachment 166595: Patch
https://bugs.webkit.org/attachment.cgi?id=166595&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166595&action=review


> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp:60
> +    FaceCacheEntry(hb_face_t* face)

Nit: explicit

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:63
> +    WTF::HashMap<uint32_t, uint16_t>* m_glyphCacheForFaceCaheEntry;

Typo: Cahe -> Cache.

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:58
> +    WTF::HashMap<uint32_t, uint16_t>* m_glyphCacheForFaceCaheEntry;

Typo here too.