[webkit-reviews] review granted: [Bug 93170] Inline continuations create :after generated content on style recalcs : [Attachment 166633] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 93170: Inline continuations create :after generated content on style
recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Attachment 166633: Patch
https://bugs.webkit.org/attachment.cgi?id=166633&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166633&action=review


> Source/WebCore/rendering/RenderInline.cpp:177
> +	       RenderObjectChildList::m_enableUpdateAfterContent = !nextTarget;


You don't need lines 176 and 177. As i said in last comment, you are explicitly
updating :before, :after content later in function, so it will place it
correctly at end.

nextTarget = currCont->inlineElementContinuation();
RenderObjectChildList::m_enableUpdateAfterContent = !nextTarget;

> Source/WebCore/rendering/RenderObjectChildList.cpp:379
> +    if (type == AFTER && !m_enableUpdateAfterContent)

You don't need to just check AFTER, make it generic and rename
m_enableUpdateAfterContent to s_enableUpdateBeforeAfterContent. For :before
content, you will bail early here instead of wasting time and going till " if
(newContentWanted && type == BEFORE && owner->isElementContinuation())"

> Source/WebCore/rendering/RenderObjectChildList.h:64
> +    static bool m_enableUpdateAfterContent;

rename to s_enableUpdateBeforeAfterContent. we s_ for statics.