[webkit-reviews] review granted: [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1. : [Attachment 166677] [EFL][UT] Refactoring an implementation of testing framework for wk1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 06:12:28 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 94925: [EFL][UT]Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925

Attachment 166677: [EFL][UT] Refactoring an implementation of testing framework
for wk1.
https://bugs.webkit.org/attachment.cgi?id=166677&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166677&action=review


Please fix them I point out, then I really hope this patch won't roll out
again. (Please check this before landing again. :-) )

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestEnvironment.h:17
> +*/

new line ?

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestEnvironment.h:27
> +    EWKTestEnvironment(bool useX11Window);

Missing explicit keyword.


More information about the webkit-reviews mailing list