[webkit-reviews] review granted: [Bug 98109] Adding Localizer::dateFormat() for multiple fields date/datetime input UI : [Attachment 166605] Patch 3

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 98109: Adding Localizer::dateFormat() for multiple fields date/datetime
input UI
https://bugs.webkit.org/show_bug.cgi?id=98109

Attachment 166605: Patch 3
https://bugs.webkit.org/attachment.cgi?id=166605&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166605&action=review


> Source/WebCore/platform/text/Localizer.h:60
> +    // Returns date format in Unicode TR35 LDML[1] containing day of month,
> +    // month, and year, e.g. "dd/mm/yyyy"
> +    // [1] LDML
http://unicode.org/reports/tr35/tr35-6.html#Date_Format_Patterns
> +    virtual String dateFormat() = 0;

Would you move this below localizedDecimalSeparator() please?
We'd like to categorize number-related functions and date/time related
functions.

Also, http://unicode.org/reports/tr35/tr35-6.html is not the latest version of
TR35.  Is it ok?