[webkit-reviews] review requested: [Bug 98109] Adding Localizer::dateFormat() for multiple fields date/datetime input UI : [Attachment 166605] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 23:32:22 PDT 2012


yosin at chromium.org has asked  for review:
Bug 98109: Adding Localizer::dateFormat() for multiple fields date/datetime
input UI
https://bugs.webkit.org/show_bug.cgi?id=98109

Attachment 166605: Patch 3
https://bugs.webkit.org/attachment.cgi?id=166605&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

Note: This patch was compiled on Mac EWS, although failed on unrelated tests:

Unexpected flakiness: text-only failures (6)
  compositing/iframes/overlapped-nested-iframes.html [ Failure Pass ]
  fast/loader/javascript-url-in-object.html [ Failure Pass ]
  http/tests/cookies/single-quoted-value.html [ Failure Pass ]
  http/tests/security/cookies/third-party-cookie-blocking-user-action.html [
Failure Pass ]
  http/tests/security/sandboxed-iframe-origin-add.html [ Failure Pass ]
  media/media-controller-playback.html [ Failure Pass ]

Unexpected flakiness: timeouts (1)
  http/tests/webarchive/test-preload-resources.html [ Timeout Pass ]


Regressions: Unexpected text-only failures : (1)
 
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection
-using-punctuation.html [ Failure ]


More information about the webkit-reviews mailing list