[webkit-reviews] review granted: [Bug 98053] Web Inspector: move completions calculation into RuntimeModel (part 1) : [Attachment 166512] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 98053: Web Inspector: move completions calculation into RuntimeModel (part
1)
https://bugs.webkit.org/show_bug.cgi?id=98053

Attachment 166512: Patch
https://bugs.webkit.org/attachment.cgi?id=166512&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166512&action=review


> Source/WebCore/inspector/front-end/RuntimeModel.js:167
> +    completionsForTextPrompt: function(textPrompt, wordRange, force,
completionsReadyCallback)

Can we get rid of dependency on TextPrompt here?

> Source/WebCore/inspector/front-end/RuntimeModel.js:170
> +	   var expressionRange =
wordRange.startContainer.rangeOfWord(wordRange.startOffset, "
=:[({;,!+-*/&|^<>", textPrompt.proxyElement, "backward");

Can you extract constant for " =:[({;,!+-*/&|^<>" and reuse it in TextPrompt?