[webkit-reviews] review granted: [Bug 97890] Web Inspector: Profiles: taking heap snapshot causes error message in console. : [Attachment 166473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 22:29:44 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 97890: Web Inspector: Profiles: taking heap snapshot causes error message
in console.
https://bugs.webkit.org/show_bug.cgi?id=97890

Attachment 166473: Patch
https://bugs.webkit.org/attachment.cgi?id=166473&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166473&action=review


> Source/WebCore/ChangeLog:18
> +	    - removed edad code in proxy;

typo: edad -> dead

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:967
> +	       this._updateTransferProgress(0, 0);

Should it be (0, this._totalNumberOfChunks) ?


More information about the webkit-reviews mailing list