[webkit-reviews] review denied: [Bug 93170] Inline continuations create :after generated content on style recalcs : [Attachment 166603] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 93170: Inline continuations create :after generated content on style
recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Attachment 166603: Patch
https://bugs.webkit.org/attachment.cgi?id=166603&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166603&action=review


One more round.

> Source/WebCore/rendering/RenderInline.cpp:169
> +    bool updateEnabled =
RenderObjectChildList::enableUpdateBeforeAfterContent(false);

you can use TemporaryChange to scope this easily. see comment below.

> Source/WebCore/rendering/RenderObjectChildList.cpp:443
> +    if (!m_enableUpdateBeforeAfterContent)

Why so late return ? Why not after the line " if (owner->style()->styleType()
== BEFORE || owner->style()->styleType() == AFTER)"

> Source/WebCore/rendering/RenderObjectChildList.h:59
> +    static bool enableUpdateBeforeAfterContent(bool enable)

You don't need this. Just use TemporaryChange.h, see
http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Test
WebKitAPI/Tests/WTF/TemporaryChange.cpp&exact_package=chromium&q=%22TemporaryCh
ange%3Cbool%22&type=cs&l=36. Make m_enableUpdateBeforeAfterContent a global
static that could be manipulated by  RenderInline::styleDidChange.