[webkit-reviews] review denied: [Bug 98109] Adding Localizer::dateFormat() for multiple fields date/datetime input UI : [Attachment 166601] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 98109: Adding Localizer::dateFormat() for multiple fields date/datetime
input UI
https://bugs.webkit.org/show_bug.cgi?id=98109

Attachment 166601: Patch 2
https://bugs.webkit.org/attachment.cgi?id=166601&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166601&action=review


> Source/WebCore/platform/text/Localizer.cpp:193
> +    if (!m_localizedDateFormatText.isEmpty())
> +	   return m_localizedDateFormatText;
> +    m_localizedDateFormatText = "dd/mm/yyyy";
> +    return m_localizedDateFormatText;

I think we had better return an empty string or make dateFormat pure virtual
because this code won't be used.

> Source/WebCore/platform/text/Localizer.h:57
> +    // Returns time format in Unicode TR35 LDML[1] containing day of month,

time -> date

> Source/WebCore/platform/text/Localizer.h:120
> +    String m_localizedDateFormatText;

should be m_dateFormat if you need this member.