[webkit-reviews] review granted: [Bug 98084] Block freeing thread should sleep indefinitely when there's no work to do : [Attachment 166587] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 98084: Block freeing thread should sleep indefinitely when there's no work
to do
https://bugs.webkit.org/show_bug.cgi?id=98084

Attachment 166587: Patch
https://bugs.webkit.org/attachment.cgi?id=166587&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166587&action=review


r=me

> Source/JavaScriptCore/heap/BlockAllocator.h:115
> +    MutexLocker mutexLocker(m_freeBlockConditionLock);
> +    if (!numberOfFreeBlocks)

"mutexLocker" should be scoped inside "if (!numberOfFreeBlocks)", so we only
acquire the mutex on the transition from zero to non-zero. Please make this
change before landing.