[webkit-reviews] review denied: [Bug 97976] Calendar picker should use zero as default step base : [Attachment 166447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 17:22:43 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97976: Calendar picker should use zero as default step base
https://bugs.webkit.org/show_bug.cgi?id=97976

Attachment 166447: Patch
https://bugs.webkit.org/attachment.cgi?id=166447&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166447&action=review


r- because of some nits

> Source/WebCore/ChangeLog:8
> +	   Calendar picker should be using zero as default step base for input
type=date.

Please add reasons why we should use zero instead of the hard minimum limit. 
e.g. specification, sync with our C++ implementation, sync with other browsers,
etc.

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:145
> +	   parameters.stepBase = 0.0;

should be 0 instead of 0.0
http://www.webkit.org/coding/coding-style.html#float-suffixes


More information about the webkit-reviews mailing list