[webkit-reviews] review granted: [Bug 97833] Encapsulate private properties in PerfTestRunner better : [Attachment 166316] Fixed a test

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 97833: Encapsulate private properties in PerfTestRunner better
https://bugs.webkit.org/show_bug.cgi?id=97833

Attachment 166316: Fixed a test
https://bugs.webkit.org/attachment.cgi?id=166316&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This is fine. A less fragile approach would be to wrap the whole file in an
anonymous function and at the end of the function only expose the things you
really want to expose, e.g.:

window.PerfTestRunner = PerfTestRunner;

That way, everything is private by default and people don't need to move code
around to enable it to use a private helper function.