[webkit-reviews] review denied: [Bug 97974] [V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-traverse gets 4% faster) : [Attachment 166528] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 1 15:56:49 PDT 2012
Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 97974: [V8] ScriptWrappable should hold the wrapper handle directly
(Dromaeo/dom-traverse gets 4% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974
Attachment 166528: Patch
https://bugs.webkit.org/attachment.cgi?id=166528&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166528&action=review
> Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.h:95
> + // OOPS! Figure out what to do here.
> + // MemoryClassInfo info(memoryObjectInfo, this,
WebCoreMemoryTypes::Binding);
> + // info.addMember(m_table);
Other than this OOPS it looks fine. :)
More information about the webkit-reviews
mailing list