[webkit-reviews] review granted: [Bug 98069] Add a GraphicsLayerFactory getter to ChromeClient : [Attachment 166543] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 15:27:47 PDT 2012


Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 98069: Add a GraphicsLayerFactory getter to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=98069

Attachment 166543: Patch
https://bugs.webkit.org/attachment.cgi?id=166543&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166543&action=review


r=me

> Source/WebCore/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

anders pls

> Source/WebCore/ChangeLog:11
> +	   * WebCore.xcodeproj/project.pbxproj:
> +	   GraphicsLayerFactory.h needs to be a private header now.

Don't think you need this, since you're forward-declaring the type.


More information about the webkit-reviews mailing list