[webkit-reviews] review granted: [Bug 93054] IndexedDB: Fire error rather than raising on request creation if transaction aborts asynchronously. : [Attachment 166507] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 93054: IndexedDB: Fire error rather than raising on request creation if
transaction aborts asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93054

Attachment 166507: Patch
https://bugs.webkit.org/attachment.cgi?id=166507&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166507&action=review


> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:90
> +	  
callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::IDB_ABORT_ERR
, "The transaction was aborted, so the request cannot be fulfilled."));

Should we share this string?  Maybe a static const char[]
IDBObjectStoreBackendImpl::abortedTransactionErrorMessage?

> Source/WebKit/chromium/tests/IDBRequestTest.cpp:72
> +    // Now simulate the back end having fired an abort error at the request
to clear up any intermediaries.
> +   
request->onError(IDBDatabaseError::create(IDBDatabaseException::IDB_ABORT_ERR,
"Description goes here."));

You're just checking that an ASSERT isn't triggered?