[webkit-reviews] review granted: [Bug 98039] [webkitpy] Detect the multiple names of the wdiff binary in the Port class. : [Attachment 166491] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 98039: [webkitpy] Detect the multiple names of the wdiff binary in the Port
class.
https://bugs.webkit.org/show_bug.cgi?id=98039

Attachment 166491: Patch
https://bugs.webkit.org/attachment.cgi?id=166491&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166491&action=review


>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1234
>> +	    for path in ("/usr/bin/wdiff", "/usr/bin/dwdiff"):
> 
> Ideally, we should just check for 'wdiff' and 'dwdiff' to be able to also
remove the implementation in chromium_mac.py, but I couldn't think of a
portable way of getting a full path from that.

perhaps we should have an is_in_the_path() abstraction somewhere that we can
reuse for things like this ...