[webkit-reviews] review denied: [Bug 96203] [XvfbDriver] First tests in each worker occasionally crash : [Attachment 166425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 11:26:27 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 96203: [XvfbDriver] First tests in each worker occasionally crash
https://bugs.webkit.org/show_bug.cgi?id=96203

Attachment 166425: Patch
https://bugs.webkit.org/attachment.cgi?id=166425&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166425&action=review


> Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py:73
> +	   time.sleep(self._port.driver_startup_delay_secs())

why don't we just sleep for 1.0 seconds here? it's not clear what the
abstraction is buying you ... wouldn't any port using xvfbdriver likely need
this?


More information about the webkit-reviews mailing list