[webkit-reviews] review denied: [Bug 93170] Inline continuations create :after generated content on style recalcs : [Attachment 166444] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 93170: Inline continuations create :after generated content on style
recalcs
https://bugs.webkit.org/show_bug.cgi?id=93170

Attachment 166444: Patch
https://bugs.webkit.org/attachment.cgi?id=166444&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166444&action=review


> Source/WebCore/rendering/RenderInline.cpp:176
> +	   if (hasPseudoAfter && !currCont->inlineElementContinuation())

These two lines are unneeded i think since you update :before, :after content
later.

197 if (!isAnonymous() &&
document()->styleSheetCollection()->usesBeforeAfterRules()) {
198	   children()->updateBeforeAfterContent(this, BEFORE);
199	   children()->updateBeforeAfterContent(this, AFTER);
200    }

> Source/WebCore/rendering/RenderInline.cpp:182
> +    if (hasPseudoAfter)

I don't like the setting/unsetting :after style hack. Also, i don't think we
want to create :before content here. So, it should be better to have like a
global bool in RenderObjectChildList and then use it to bail out in
RenderObjectChildList::updateBeforeAfterContent. Then you can set/unset it here
with a TemporaryChange around the for loop. Basically the gist is we shouldn't
be updating our :before, :after while we are inside the for loop.