[webkit-reviews] review granted: [Bug 98020] Fix compilation warnings : [Attachment 166459] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 98020: Fix compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=98020

Attachment 166459: Patch
https://bugs.webkit.org/attachment.cgi?id=166459&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166459&action=review


>>> Source/WebCore/plugins/PluginView.cpp:1482
>>> +	 UNUSED_PARAM(plen);
>> 
>> You can remove these arguments too?
> 
> Frankly I don't like removing arguments, especially in EFL port.
> By removing those, we lose information. 
> 
> By using UNUSED_PARAM(), if someone want to extend
PluginView::getAuthenticationInfo() in the future, it is easy. If I remove
argument names, it is not obvious what the char* refer to and which one is the
username, which one is the password.

OK