[webkit-reviews] review denied: [Bug 97999] [WebSocket] Setting wrong value to binaryType should not raise exception : [Attachment 166420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 01:34:28 PDT 2012


Yuta Kitamura <yutak at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97999: [WebSocket] Setting wrong value to binaryType should not raise
exception
https://bugs.webkit.org/show_bug.cgi?id=97999

Attachment 166420: Patch
https://bugs.webkit.org/attachment.cgi?id=166420&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166420&action=review


r- for unneeded |ExceptionCode&| argument.

> Source/WebCore/Modules/websockets/WebSocket.cpp:407
> +void WebSocket::setBinaryType(const String& binaryType, ExceptionCode&)

Well, what I meant was to update the following line in WebSocket.idl:

    attribute [TreatReturnedNullStringAs=Undefined] DOMString binaryType
	setter raises(DOMException);

If you remove "setter raises(DOMException)", you will not need the second
argument
of setBinaryType().

(You can also remove [TreatReturnedNullStringAs=Undefined]. It was used to
handle
 the old hixie76 protocol, which is no longer supported.)


More information about the webkit-reviews mailing list