[webkit-reviews] review denied: [Bug 97999] [WebSocket] Setting wrong value to binaryType should not raise exception : [Attachment 166417] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97999: [WebSocket] Setting wrong value to binaryType should not raise
exception
https://bugs.webkit.org/show_bug.cgi?id=97999

Attachment 166417: Patch
https://bugs.webkit.org/attachment.cgi?id=166417&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166417&action=review


r- for unused function argument.

> Source/WebCore/Modules/websockets/WebSocket.cpp:417
> +    scriptExecutionContext()->addConsoleMessage(JSMessageSource,
LogMessageType, ErrorMessageLevel, "'" + binaryType + "' is the wrong
binaryType");

- Error message sounds a bit strange and unhelpful; I would suggest:
    "'" + binaryType + "'" is not a valid value for binaryType; binaryType
remains unchanged."

- You can now remove the argument |ec|. You need to touch WebSocket.idl to
remove this.