[webkit-reviews] review granted: [Bug 103665] [mathml] Improve performance of nested sup or sub elements : [Attachment 177075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 30 20:34:03 PST 2012


Darin Adler <darin at apple.com> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 103665: [mathml] Improve performance of nested sup or sub elements
https://bugs.webkit.org/show_bug.cgi?id=103665

Attachment 177075: Patch
https://bugs.webkit.org/attachment.cgi?id=177075&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177075&action=review


> Source/WebCore/ChangeLog:15
> +	   (msup): Stretching children also cause extra layouts. Avoid this by
aligning to the top.

Should be "causes", not "cause".

> LayoutTests/ChangeLog:9
> +	   The pixel results should be the same, this is only a change to the
render tree.

This is the perfect place to explain why the render tree changed; saying the
changes in MathML’s CSS file affects the position of the boxes, but not
painting or hit testing. If that’s correct.


More information about the webkit-reviews mailing list