[webkit-reviews] review denied: [Bug 103752] Web Inspector: Add ability to view printable output for webpage : [Attachment 176980] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 103752: Web Inspector: Add ability to view printable output for webpage
https://bugs.webkit.org/show_bug.cgi?id=103752

Attachment 176980: Patch
https://bugs.webkit.org/attachment.cgi?id=176980&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176980&action=review


> Source/WebCore/inspector/Inspector.json:435
> +		       { "name": "enabled", "type": "boolean", "description":
"Whether the printed media emulation should be enabled." }

Lets keep it generic in the protocol.

> Source/WebCore/inspector/front-end/SettingsScreen.js:331
> +	   const p = document.createElement("p");

This should be a part of the overrides

>> Source/WebCore/page/FrameView.cpp:1339
>> +	    overrideType = "print";
> 
> Why not make it generic -- i.e. allow to override to arbitrary media type?

+1